Transfer cache speed test #6362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6362 +/- ##
=============================================
- Coverage 69.80% 69.73% -0.07%
- Complexity 17944 18025 +81
=============================================
Files 2046 2057 +11
Lines 76678 76970 +292
Branches 7830 7846 +16
=============================================
+ Hits 53526 53677 +151
- Misses 20411 20546 +135
- Partials 2741 2747 +6 ☔ View full report in Codecov by Sentry. |
habrahamsson-skanetrafiken
requested review from
t2gran and
habrahamsson-skanetrafiken
habrahamsson-skanetrafiken
previously approved these changes
Jan 9, 2025
t2gran
reviewed
Jan 13, 2025
application/src/test/java/org/opentripplanner/transit/speed_test/SpeedTest.java
Outdated
Show resolved
Hide resolved
t2gran
reviewed
Jan 13, 2025
application/src/test/java/org/opentripplanner/transit/speed_test/SpeedTest.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
force-pushed
the
transfer-cache-speed-test
branch
from
64b10c2 to
041d1bb
Compare
leonardehrenfried
force-pushed
the
transfer-cache-speed-test
branch
from
0363fc8 to
ebbee33
Compare
leonardehrenfried
force-pushed
the
transfer-cache-speed-test
branch
from
ebbee33 to
25ffb73
Compare
|
I have extracted the transfer cache test into a separate file that is run separately. |
habrahamsson-skanetrafiken
requested changes
Jan 15, 2025
| */ | ||
| class SetupHelper { | ||
|
|
||
| static LoadModel loadGraph(File baseDir, URI path) { |
There was a problem hiding this comment.
path should be @Nullable here
application/src/test/java/org/opentripplanner/transit/speed_test/TransferCacheTest.java
Outdated
Show resolved
Hide resolved
t2gran
approved these changes
Jan 17, 2025
habrahamsson-skanetrafiken
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It turns out we have a pretty big blind spot in our speed tests: transfer cache computation is not measured at all. This is added in this PR.
You can see a preview of this data here: https://tinyurl.com/224xmjfe
Issue
Relates to #6357